Open
Conversation
…th dark navigation bar)
Contributor
|
Just curious here: does |
Author
|
Haven't tested different styles within one app, but as far as I know a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using MRProgress in several apps. In all apps it seems to be a good idea to choose the same background color like the navigation bar (if one apparent) as the default background color of the progress view. So I changed all default coloring implementation to automatically change to a dark coloring (by simply inverting the colors) when the status bar style is set to
LightContent.Maybe you want to consider to integrate this into MRProgress or think about a similar solution. I've read #59 and couldn't find another working solution for a background tint yet. So I came up with this automatic one. Hope you like it.