msm servername config fix failure to update string with a /#450
Open
unnilennium wants to merge 2 commits into
Open
msm servername config fix failure to update string with a /#450unnilennium wants to merge 2 commits into
unnilennium wants to merge 2 commits into
Conversation
prevent error when / are present in the value of the config as when changing any config with a path or as in version where a / is expected.
using an invisible delimiter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent error when / are present in the value of the config as when changing any config with a path or as in version where a / is expected.
this will fix issue # 371.
rather than using a # , using an invisible delimiter reduce even more the risk of a user deciding to add a the delimiter in the config value.