fix(browser): restore setupWorker lifecycle#2682
Closed
felmonon wants to merge 1 commit intomswjs:fix/define-networkfrom
Closed
fix(browser): restore setupWorker lifecycle#2682felmonon wants to merge 1 commit intomswjs:fix/define-networkfrom
felmonon wants to merge 1 commit intomswjs:fix/define-networkfrom
Conversation
Member
|
Hi! I am super confused what you are doing here. Are there any problems you were trying to solve with these? Also, are you using LLMs to generate your pull requests? |
Contributor
Author
|
Thanks for calling that out. You're right that I should have made the problem statement much clearer. This PR was meant to address three browser lifecycle regressions I hit on
The added browser tests were meant to lock those behaviors down. I do use LLM tooling sometimes to help draft and iterate, but I only push changes I can reproduce and validate locally. If these behaviors are intentional on this branch, or if I'm missing the intended direction, I'm happy to close this rather than add noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #2650.
Summary
worker.start()/worker.stop()cyclesServiceWorkerRegistrationreturn value on redundantworker.start()callsworker.stop()while preserving post-stop passthrough and restart behaviorworker.start(), restart after stop, and keepalive cleanupTesting
pnpm buildpnpm test:browser -- test/browser/msw-api/setup-worker/start/start.test.ts test/browser/msw-api/setup-worker/stop.test.ts test/browser/msw-api/setup-worker/stop/keepalive.test.ts