Skip to content

Remove setEventManager from class Composer #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Erikvv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove setEventManager from class Composer #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions src/Service/Composer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,14 @@
use MtMail\Template\TemplateInterface;
use MtMail\Template\TextTemplateInterface;
use Zend\EventManager\EventManager;
use Zend\EventManager\EventManagerAwareInterface;
use Zend\EventManager\EventManagerInterface;
use Zend\Mail\Message;
use Zend\View\Model\ModelInterface;
use Zend\Mime\Message as MimeMessage;
use Zend\Mime\Part as MimePart;
use Zend\View\Model\ViewModel;

class Composer implements EventManagerAwareInterface
class Composer
{
/**
* @var RendererInterface
Expand All @@ -46,19 +45,6 @@ public function __construct(RendererInterface $renderer)
$this->renderer = $renderer;
}

/**
* Inject an EventManager instance
*
* @param EventManagerInterface $eventManager
* @return self
*/
public function setEventManager(EventManagerInterface $eventManager)
{
$this->eventManager = $eventManager;

return $this;
}

/**
* Retrieve the event manager
*
Expand Down
14 changes: 4 additions & 10 deletions test/MtMailTest/Service/ComposerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,20 +70,15 @@ public function testComposeRendersViewModelAndAssignsSubjectIfProvidedByViewMode
$this->assertEquals('MAIL_SUBJECT', $message->getSubject());
}

public function testServiceIsEventManagerAware()
{
$em = new EventManager();
$this->service->setEventManager($em);
$this->assertEquals($em, $this->service->getEventManager());
}

public function testComposeTriggersEvents()
{
$renderer = $this->prophesize(RendererInterface::class);
$renderer->render(Argument::type(ModelInterface::class))
->willReturn('MAIL_BODY');

$em = new EventManager();
$service = new Composer($renderer->reveal());
$em = $service->getEventManager();

$listener = function ($event) {
$this->assertInstanceof(
ComposerEvent::class,
Expand Down Expand Up @@ -118,8 +113,7 @@ public function testComposeTriggersEvents()
$listener
);

$service = new Composer($renderer->reveal());
$service->setEventManager($em);

$template = new HtmlTemplate();
$service->compose([], $template, new ViewModel());

Expand Down