Fix view location setting not being respected#53
Open
growlf wants to merge 2 commits into
Open
Conversation
- Check if existing view is in correct location before revealing - Add fixViewLocation() method to correct workspace restoration - Detach and recreate view if in wrong location (sidebar vs main) - Fixes issue where workspace.json restores view to wrong location
Author
|
Side note: this PR was generated (with opencode) while using the plugin with Obsidian as the tool to both test and resolve the issue. |
- Added comments to fixViewLocation() explaining the workspace.json bug - Added comments to activateView() explaining why we check location before reveal - Added comments to onLayoutReady() explaining the 100ms delay - Documents the problem: Obsidian ignores user settings when restoring workspace
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where the `defaultViewLocation` setting (sidebar vs main window) is not respected when:
Changes Made
1. `src/ui/ViewManager.ts`
2. `src/main.ts`
How to Test
Related Issue
Fixes behavior where `workspace.json` restores view to sidebar regardless of settings.
Note: This PR is a draft for review. Changes are from a fork at `growlf/opencode-obsidian`.