fix: WSL custom command mode + add known issue warning#59
Open
shf-275599 wants to merge 4 commits into
Open
Conversation
Use a stricter runtime check before entering custom command mode. ServerManager.start() now derives a local useCustomCommand flag from: - settings.useCustomCommand - a non-empty trimmed customCommand That flag is then used consistently for startup branching, startup mode logging, and ENOENT error reporting. This makes startup behavior more predictable when OpenCode is launched through a wrapper command instead of a direct executable path, including Windows Obsidian setups that start WSL-hosted OpenCode via wsl.exe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Fix: Custom command mode logic
File:
src/server/ServerManager.tsProblem: The original code only checks
useCustomCommandsetting without verifying ifcustomCommandis empty. This causes issues in WSL environment where the plugin may incorrectly enter custom command mode even when no custom command is configured.Fix:
useCustomCommandand whethercustomCommandis empty2. Docs: Add known issue warning
File:
README.mdAdded a prominent warning at the top of README:
Issues Resolved
Testing Environment