fix(handler): validate skill id UUID at request boundary#3025
Open
tomqiaozc wants to merge 1 commit into
Open
Conversation
loadSkillForUser was passing chi.URLParam(r, "id") directly into
parseUUID, the panic-on-invalid helper reserved for trusted UUID
round-trips. A malformed `/api/skills/{notuuid}` request panicked
in util.MustParseUUID; chi's middleware.Recoverer turned it into a
500 instead of a 400.
This violates the documented convention (CLAUDE.md → "Backend Handler
UUID Parsing Convention"): pure-UUID request inputs must use
parseUUIDOrBadRequest, which writes a 400 and short-circuits.
Switch loadSkillForUser to parseUUIDOrBadRequest. Behaviour for valid
UUIDs is unchanged; malformed input now returns 400 with a clear
"invalid skill id" message.
Test:
- TestGetSkill_MalformedUUIDReturns400 asserts GET /api/skills/not-a-uuid
returns 400.
|
@tomqiaozc is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3024.
loadSkillForUserwas passing the rawchi.URLParam("id")intoparseUUID, the panic-on-invalid helper reserved for trusted UUID round-trips. A malformed/api/skills/{notuuid}panicked inutil.MustParseUUID; chi'smiddleware.Recovererturned the panic into a 500 instead of a 400.This violates
CLAUDE.md→ Backend Handler UUID Parsing Convention: pure-UUID request inputs must useparseUUIDOrBadRequest. Switching to it makes the behavior:400 Bad Requestwith{"error":"invalid skill id"}and no panic log.Test plan
TestGetSkill_MalformedUUIDReturns400assertsGET /api/skills/not-a-uuidreturns 400.TestGetSkill_IncludesContentandTestListSkills_OmitsContentstill pass (valid UUID path unchanged).make test(reviewer-side; my local environment lacks Go).