issue / production-mode-code-compiler-refactor#78
Merged
kurtmancelik-inventiv merged 3 commits intomainfrom Mar 17, 2025
Merged
issue / production-mode-code-compiler-refactor#78kurtmancelik-inventiv merged 3 commits intomainfrom
kurtmancelik-inventiv merged 3 commits intomainfrom
Conversation
…ışında referansı yok, * OptimizedMethodInvokerTemplate içerisinde metodun Name prop'unu get ederken kullanılan GetHashCode() metodu constructor'a taşındı ve instance başına 1 defa oluşması sağlandı, eski kullanımda Name prop'u her çağrıldığında yeni dönüyordu ve - değer oluşturabildiği için compile edilecek kod çıktısını bozuyordu, - OptimizedMethodInvokerTemplate disposable hale getirildi, sadece ReflectionOptimizer ile kullanılıyor ve içeride ürettiği string bilgi kullanımdan sonra dispose edilmeli. (kod compile edilip Assembly olarak yükleniyor zaten.) - Unit Testlerde WaitForOptimization metodu, threadi kitlememesi için Thread.SpinWait'e çevrildi ve counter iptal edilip, compilation bitene kadar bekletildi, - ReflectionOptimizer Optimize metodunda _method obje count'ı 0 ise yeni CodeCompiler instance'ı oluşturması engellendi,
added 2 commits
March 6, 2025 12:02
* SonarCloud OptimizedMethodInvokerTemplate Disposable pattern refactor
|
|
inventivEng
reviewed
Mar 7, 2025
sametemek
reviewed
Mar 14, 2025
mmucahitballi
requested review from
mmucahitballi
and removed request for
mmucahitballi
kurtmancelik-inventiv
deleted the
issue/production-mode-code-compiler-refactor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
İşler