-
Notifications
You must be signed in to change notification settings - Fork 153
Crowdfunding update #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crowdfunding update #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the crowdfunding tutorial to use the latest MultiversX framework (v0.64.1), reorganizes the tutorial structure into multiple parts, and modernizes the testing approach from scenario-based to blackbox testing.
Changes:
- Updated crowdfunding tutorial structure from 2 parts to 3 parts with a final code reference page, moving files to a new
crowdfunding/subdirectory - Migrated from deprecated waltz library to custom markdown parser using pulldown-cmark for code extraction
- Replaced JSON scenario tests with modern blackbox tests supporting both EGLD and ESDT tokens
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| testing/rust-tutorial-ci.sh | Updated script to use proper path handling and changed directory from crowdfunding-esdt to crowdfunding |
| testing/extract-tutorial-code/src/parser.rs | New markdown parser implementation replacing waltz dependency |
| testing/extract-tutorial-code/src/extract_code.rs | Refactored to use custom parser and extract blackbox test files instead of JSON scenarios |
| testing/extract-tutorial-code/Cargo.toml | Updated to Rust edition 2024 and pulldown-cmark 0.13 |
| testing/crowdfunding/* | New crowdfunding contract files including proxy, config, and metadata |
| testing/crowdfunding-esdt/tests/crowdfunding_scenario_rs_test.rs | Removed old scenario-based tests |
| sidebars.js | Reorganized crowdfunding tutorial into a category with 4 parts |
| rust-toolchain.toml | Added Rust 1.92 toolchain specification |
| docusaurus.config.js | Added redirects for old crowdfunding tutorial URLs |
| docs/developers/tutorials/crowdfunding/* | New tutorial structure with parts 1-3 and final code reference |
| docs/developers/testing/sc-debugging.md | Updated reference from crowdfunding-esdt to crowdfunding |
| docs/developers/testing/rust/whitebox-legacy.md | Updated reference from crowdfunding-esdt to crowdfunding |
| docs/developers/overview.md | Updated tutorial links to new paths |
| docs/developers/developer-reference/sc-payments.md | Updated deprecation note from 0.64.0 to 0.64.1 |
| Cargo.toml | Added resolver 3 and updated crowdfunding directory exclusion |
| .github/workflows/rust-tutorial-ci.yml | Updated GitHub Actions versions and Rust toolchain to 1.92 |
Comments suppressed due to low confidence (2)
testing/crowdfunding/meta/Cargo.toml:4
- Rust edition '2024' does not exist. The valid Rust editions are 2015, 2018, and 2021. Change this to 'edition = "2021"'.
docs/developers/tutorials/crowdfunding/crowdfunding-p1.md:85 - Rust edition '2024' does not exist in the tutorial documentation. The valid Rust editions are 2015, 2018, and 2021. This should be 'edition = "2021"'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The base branch was changed.
Description of the pull request (what is new / what has changed)
This PR updates the crowdfunding tutorial to use the latest MultiversX framework (v0.64.1), reorganizes the tutorial structure into multiple parts, and modernizes the testing approach from scenario-based to blackbox testing.
Changes:
Did you test the changes locally ?
Which category (categories) does this pull request belong to?