Skip to content

Add audio-analysis coverage panel to provider settings#1783

Open
chrisuthe wants to merge 14 commits into
music-assistant:mainfrom
chrisuthe:feat/aa-coverage-panel
Open

Add audio-analysis coverage panel to provider settings#1783
chrisuthe wants to merge 14 commits into
music-assistant:mainfrom
chrisuthe:feat/aa-coverage-panel

Conversation

@chrisuthe
Copy link
Copy Markdown
Member

@chrisuthe chrisuthe commented May 19, 2026

Adds a self-contained coverage panel above Search/add-provider on /settings/providers?types=audio_analysis: per-provider analyzed/pending coverage bar, stale & version columns, plus a read-only background-scan status line.
image

Sourced entirely from existing APIs (audio_analysis/coverage, tasks/get) — no server changes.

Depends on music-assistant/server#3851

@OzGav
Copy link
Copy Markdown
Contributor

OzGav commented May 19, 2026

Screenshot?

chrisuthe added 4 commits May 19, 2026 11:57
…e state

Adopt the audio_analysis/status endpoint as the authoritative loaded-state and analysis_version probe per provider, then fetch audio_analysis/coverage only for loaded providers. A rejecting or provider_loaded:false status now overrides an optimistic api.providers flag (row marked unavailable, no coverage call); a loaded provider whose coverage call fails still surfaces as an error row with the version from status.
Replace the hand-rolled table and scoped hex CSS with Card/Item/Progress/Badge primitives and semantic Tailwind tokens, matching the settings visual standards (cf. About.vue). No data or composable changes; test DOM contract and i18n keys preserved.
… of the page

The coverage panel was mounted raw at the top of Providers.vue with no wrapper, so it bled to the viewport edges while the header/total/list below all use the page's 20px (px-5) gutter. Wrap the mount in px-5 pt-5 to match; component stays layout-agnostic.
@chrisuthe chrisuthe marked this pull request as ready for review May 19, 2026 20:34
@OzGav
Copy link
Copy Markdown
Contributor

OzGav commented May 19, 2026

Nice. Not sure how easy it would be to add my AcoustID provider. We would have to know how many tracks are missing a musicbrainz recording ID first….

@MarvinSchenkel
Copy link
Copy Markdown
Contributor

I think it is a bit weird to show this by default at the top of the screen. Let's make a button next to 'add provider' that just opens a new breadcrumb settings > audio analysis > coverage (or something) that shows this overview?

chrisuthe added a commit to chrisuthe/frontend that referenced this pull request May 20, 2026
Coordinate with frontend PR music-assistant#1783 (audio-analysis coverage panel) and
server PR #3851 (centralised audio_analysis API):

- Remove per-row AA status badges from Providers.vue + the
  settings.aa_provider.* strings; PR music-assistant#1783's coverage panel owns this
  surface and would render duplicate information.
- Rewire getSonicAnalysisStatus() to audio_analysis/status with
  aa_domain=sonic_analysis, and add getAaProviderCoverage(aa_domain)
  for audio_analysis/coverage. Drop the unused getAaProviderStatus()
  helper that only existed to feed the per-row badges.
- Refactor SonicSimilarityStatusPanel: read aa_provider_domain from
  sonic_similarity/status, then fetch audio_analysis/coverage for that
  domain. Coverage % is now index_size / (analyzed + pending) and works
  for any AA backend (sonic_analysis today, loudness later) without
  code changes.

Add the AaProviderCoverage interface ({analyzed, pending, stale_version,
analysis_version}) matching #3851's response shape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants