Skip to content

Add AUDIO_OVERLAY to ProviderFeature enum#221

Merged
MarvinSchenkel merged 1 commit into
music-assistant:mainfrom
jlpouffier:feature/audio-overlay-provider-feature
May 13, 2026
Merged

Add AUDIO_OVERLAY to ProviderFeature enum#221
MarvinSchenkel merged 1 commit into
music-assistant:mainfrom
jlpouffier:feature/audio-overlay-provider-feature

Conversation

@jlpouffier
Copy link
Copy Markdown
Member

@jlpouffier jlpouffier commented May 7, 2026

Summary

  • Adds AUDIO_OVERLAY = "audio_overlay" to the ProviderFeature enum
  • Allows plugin providers to declare overlay capability so the streams controller can discover them by feature flag
  • Required by music-assistant/server#3844 to address review feedback on the generic overlay architecture

Test plan

  • Server PR #3844 (updated) uses this feature flag to look up active overlay providers
  • Rainy Mood plugin declares ProviderFeature.AUDIO_OVERLAY in its SUPPORTED_FEATURES

🤖 Generated with Claude Code

Allows plugin providers to declare overlay capability so the streams
controller can discover them by feature flag rather than duck-typing.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@MarvinSchenkel MarvinSchenkel marked this pull request as ready for review May 13, 2026 10:42
@MarvinSchenkel
Copy link
Copy Markdown
Contributor

Thanks @jlpouffier 🙏

@MarvinSchenkel MarvinSchenkel merged commit d5ced85 into music-assistant:main May 13, 2026
3 checks passed
github-actions Bot pushed a commit to music-assistant/server that referenced this pull request May 14, 2026
Update music-assistant-models to version
[1.1.118](https://github.com/music-assistant/models/releases/tag/1.1.118)


- Add AUDIO_OVERLAY to ProviderFeature enum (by @jlpouffier in
[#221](music-assistant/models#221))

## 🧰 Maintenance and dependency bumps

- Build(deps-dev): Bump pre-commit from 4.5.1 to 4.6.0 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[#220](music-assistant/models#220))
- Build(deps): Bump release-drafter/release-drafter from 7.2.1 to 7.3.0
(by @[dependabot[bot]](https://github.com/apps/dependabot) in
[#222](music-assistant/models#222))
- Build(deps-dev): Bump mypy from 1.20.2 to 2.0.0 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[#223](music-assistant/models#223))


## 🙇 Contributors

@MarvinSchenkel and @jlpouffier

Co-authored-by: marcelveldt <6389780+marcelveldt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants