Add is_dynamic field to PlayerQueue#224
Open
dmoo500 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
is_dynamicfield toPlayerQueueso all clients can check directly whether a dynamic playlist is the active radio source, without having to inspectradio_sourcemanually.Background
Previously, clients had to implement the detection logic themselves:
This was duplicated in the web frontend and would need to be reimplemented in every client (mobile app, etc.).
Change
Adds
is_dynamic: bool = Falseas a serialized field onPlayerQueue. The server sets this field wheneverradio_sourcechanges.Why a stored field instead of
@property:PlayerQueueuses mashumaro'sDataClassDictMixin. Itsto_dict()/to_cache()serialization only processes dataclass fields —@propertyaccessors are silently skipped and would never reach the wire or the cache, so clients would always see the default value. Verified with a minimal test against the installed mashumaro version.Related