Keep Sendspin stream open on skip/seek via stream/clear messages#3870
Draft
maximmaxim345 wants to merge 2 commits into
Draft
Keep Sendspin stream open on skip/seek via stream/clear messages#3870maximmaxim345 wants to merge 2 commits into
stream/clear messages#3870maximmaxim345 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While Sendspin has a
stream/clearmessage specifically ment for skips and seeks, it wasn't used by Music Assistant before.Instead of the
stream/clearmessage, Music Assistant/aiosendspin instead sent astream/endmessage immediately followed by astream/startmessage.While both approaches to handle skips are valid by the Specification, using
stream/clearcan allow client implementations to handle track seeks and skips more efficiently.Additionally this will show gaps in client implementations, ensuring that they correctly implement the Specification to properly work with Music Assistant.
Related:
stream/endmessage Sendspin/spec#83Draft:
PushStreamSendspin/aiosendspin#245 being merged and releasedsendspin-cpphave issues handlingstream/clearmessages (fixed in Handle stream/clear internally Sendspin/sendspin-cpp#54)