Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive logging functionality alongside significant new features including a WorkerPool implementation for concurrent task processing, API refactoring to support multi-queue task retention, and HTTP middleware support for better request handling.
Changes:
- Added logging integration throughout the codebase with structured logging via logger package
- Implemented WorkerPool with concurrent worker support for processing tasks and tickers
- Refactored task/ticker APIs to support multiple queue selection (variadic queues parameter)
- Added HTTP middleware support for all handler registration functions
- Changed HTTP method from GET to PUT for task retention operations (more semantically correct)
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/queue/workerpool.go | New WorkerPool implementation for concurrent task/ticker processing |
| pkg/queue/workerpool_test.go | Test suite for WorkerPool (has critical missing imports) |
| pkg/queue/opts.go | Functional options for WorkerPool configuration |
| pkg/queue/task.go | Refactored NextTask/RunTaskLoop to support multiple queues |
| pkg/queue/ticker.go | Added RunTickerLoop (non-namespace) method |
| pkg/queue/manager.go | Added logging support and error aggregation in cleanup |
| pkg/queue/sql/*.sql | Updated queue_lock to accept array of queue names |
| pkg/queue/schema/task.go | Changed TaskRetain to use Queues array |
| pkg/queue/httphandler/*.go | Added middleware support to all handler registrations |
| pkg/queue/httpclient/task.go | Updated RetainTask to support variadic queue parameter |
| pkg/queue/doc.go | Added package documentation with examples |
| cmd/pgqueue/main.go | Added logger initialization with terminal detection |
| cmd/pgqueue/server.go | Integrated logging middleware and trace functionality |
| cmd/pgqueue/task.go | Updated CLI to support multi-queue task retention |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 35 out of 35 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.