Fix LM:NTLM hash parsing causing ADWS bind failure#2
Open
NathanielSlw wants to merge 1 commit intomverschu:mainfrom
Open
Fix LM:NTLM hash parsing causing ADWS bind failure#2NathanielSlw wants to merge 1 commit intomverschu:mainfrom
NathanielSlw wants to merge 1 commit intomverschu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: NTLM Hash Authentication with LM:NTLM Format
🐛 Problem
When using NTLM hash authentication in the standard impacket format
LM:NTLM, the tool throws an error:Reproducible with:
🔍 Root Cause
The
bind()method inadws_wrapper.pydoesn't split theLM:NTLMformat before passing it toNTLMAuth. When_fix_hashes()inms_nns.pytries to convert the full string usingbytes.fromhex(), it fails at position 32 where the:separator exists (which is not a valid hex character).✅ Solution
Split the
LM:NTLMformat before passing toNTLMAuth, and send only the NT hash (second part) to the authentication class.Change in
adws_wrapper.py-bind()method:🧪 Testing
Before fix: Error at position 32 (colon separator)
After fix: Authentication succeeds with
LM:NTLMformat📋 Technical Details
The
LM:NTLMformat contains:aad3b435b51404eeaad3b435b51404eeOnly the NT Hash is required for modern NTLM authentication. The LM hash remains for backward compatibility but is not used in current Windows environments.