fix(kiro): always attach profileArn to chat requests#20
Merged
Conversation
Upstream now rejects generateAssistantResponse without profileArn (400 "profileArn is required for this request."). Add kiroResolveProfileArn: API-key auth sends only key-resolved ARN (foreign ARN 403s); OAuth/social prefers resolved ARN, falls back to shared default keyed by auth method. Add kiroDefaultProfileArn mapping social sign-ins (google/github/imported/social) to social profile, others to builder-id profile. Use resolver in Stream; replace hardcoded ARN in FetchQuota. Add TestKiroResolveProfileArn covering OAuth fallback, API-key, and resolved-ARN cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream now rejects
generateAssistantResponsewithoutprofileArn(400 "profileArn is required for this request."). This change ensures aprofileArnis always attached to Kiro chat requests.Changes
kiroResolveProfileArn:kiroDefaultProfileArnmapping social sign-ins (google/github/imported/social) to the social profile, and others to the builder-id profile.Stream; replace the hardcoded ARN inFetchQuota.Tests
TestKiroResolveProfileArncovering OAuth fallback, API-key, and resolved-ARN cases.