Fix server startup issues on Python 3.12+#1
Open
akbad wants to merge 2 commits into
Open
Conversation
…patibility) and adapt to new API - Upgrade FastMCP from 2.4.0 to >=2.11.2 (fixes Pydantic field bug) - Refactor tool registration to use `@server.tool()` decorators (required by new FastMCP version) - Migrate SSE path config to use env variables (since prev method is now deprecated by FastMCP) All changes are interdependent to maintain the server in a working state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hi, I ran into problems trying to start the server after installing it using
uv sync.This PR fixes the 2 issues required to get the server to start on Python 3.12+.
The server now successfully starts using:
uv run python -m src.main(as in the README)uv run sourcegraph-mcpalso works, of courseuv run python src/main.pyFixes
Import path mismatch (fixed in f39dd6d)
from server import ...)from sourcegraph_mcp.server import ...)FastMCP issues (fixed in 5fe47fe)
fastmcpdep from==2.4.0to>=2.11.2(to integrate upstream fix for Python 3.12+ "default vs default_factory" bug)@server.tool()decorators (as needed by newFastMCP API)
FASTMCP_SSE_PATH,FASTMCP_MESSAGE_PATH) and updated Dockerfile,.env.sample, and README accordingly