Skip to content

Add support for formatting large request bodies#22

Open
adduc wants to merge 3 commits intonamshi:masterfrom
adduc:20-large-request-bodies
Open

Add support for formatting large request bodies#22
adduc wants to merge 3 commits intonamshi:masterfrom
adduc:20-large-request-bodies

Conversation

@adduc
Copy link
Copy Markdown

@adduc adduc commented Mar 2, 2018

PHP's escapeshellarg throws a fatal error on bad input (null bytes, strings that are too long). To workaround this, use symfony/process to escape arguments instead.

Version 3 of symfony/process was used instead of 4 because of Cuzzle's support for PHP 5.5

Solves #20

LeTucTuc
LeTucTuc previously approved these changes May 6, 2020
cholladay0816
cholladay0816 previously approved these changes Mar 10, 2021
Comment thread composer.json Outdated
"guzzlehttp/guzzle": "^6.0",
"psr/log": "^1.0"
"psr/log": "^1.0",
"symfony/process": "^3.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ^3.0|^4.0|^5.0 otherwise it cannot be installed on newer symfony versions

matheustiny
matheustiny previously approved these changes Oct 1, 2021
@adduc adduc dismissed stale reviews from matheustiny, cholladay0816, and LeTucTuc via a9b35a8 November 10, 2021 06:38
@bigfoot90
Copy link
Copy Markdown

This repo seems to be unmaintained now.
This same task was accomplished by a forked repository https://github.com/octoper/cuzzle/pull/1/files
@adduc Please open a new MR on october/cuzzle repo, and post. this same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants