WIP: feat time domain solar wind covariance#1966
Conversation
…uble; add tests for time domain solar wind; add tests for noise design matrix precision
…are not changing; add tests
scottransom
left a comment
There was a problem hiding this comment.
There's a lot in here and it is beyond me to go through carefully line-by-line! We definitely need to make sure that there are some test cases and/or examples available that provide results that you believe are correct.
|
thanks for the comments, Scott ! I will take a look and see about implementing them. |
…INT into feat/jgb-td-solar-wind-gp
…nterprise and discovery
| ) | ||
|
|
||
|
|
||
| def get_phiinv(phi: np.ndarray) -> np.ndarray: |
There was a problem hiding this comment.
This could use a slightly more explicit docstring (explaining parameters and return values)
There was a problem hiding this comment.
(also I see some typos in utils.py, so you could fix paremeters -> parameters
|
Maybe @abhisrkckl can look at this, since it involves changes to the noise model and some of the whitened residual pieces he put in recently? |
|
Is this ready to be looked at? |
Yes ! I just need to get the black to pass. I think I have been using the wrong line length settings. |
Needed for NG20.
Major changes
More work should really explore additional caching of various parts of the GLS fit when the noise model is being held constant. This might be sub blocks of the design matrix. Or a refactorization of the GLS implementation.
TODO
Disclosure that I used co-pilot for generating the unit tests as well as some docstrings and type hinting.