Skip to content

Improved version of make_ecc_interpolant#446

Open
abhisrkckl wants to merge 2 commits into
nanograv:devfrom
abhisrkckl:ecc-nharm
Open

Improved version of make_ecc_interpolant#446
abhisrkckl wants to merge 2 commits into
nanograv:devfrom
abhisrkckl:ecc-nharm

Conversation

@abhisrkckl
Copy link
Copy Markdown

@abhisrkckl abhisrkckl commented Apr 29, 2026

Implements a more conservative expression for the number of harmonics needed to accurately represent an eccentric waveform, based on https://arxiv.org/abs/2210.11454.
image

image

@abhisrkckl abhisrkckl changed the title make_ecc_interpolant Improved version of make_ecc_interpolant Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.54%. Comparing base (ebadc2f) to head (34e9657).
⚠️ Report is 99 commits behind head on dev.

Files with missing lines Patch % Lines
enterprise/signals/utils.py 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #446      +/-   ##
==========================================
- Coverage   72.59%   72.54%   -0.06%     
==========================================
  Files          13       13              
  Lines        3478     3478              
==========================================
- Hits         2525     2523       -2     
- Misses        953      955       +2     
Files with missing lines Coverage Δ
enterprise/signals/utils.py 81.80% <0.00%> (-0.39%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423c38b...34e9657. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant