Add idx_exclude to MarginalizingTimingModel#451
Open
vhaasteren wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #451 +/- ##
==========================================
+ Coverage 72.59% 72.71% +0.11%
==========================================
Files 13 13
Lines 3478 3478
==========================================
+ Hits 2525 2529 +4
+ Misses 953 949 -4
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idx_excludeparameter toMarginalizingTimingModel, mirroring the existing API onTimingModel.This is a small API parity change. It lets callers marginalize over a subset of timing-model columns while handling the excluded ones elsewhere — for example, when a nonlinear delay term samples some parameters and the remaining linear timing parameters are marginalized analytically.
Test plan
pytest tests/test_gp_signals.py::TestGPSignals::test_marginalizing_timing_model_idx_excludepytest tests/test_likelihood.py::TestLikelihood::test_like_marginalizing_tm_idx_exclude