fix(charts): quote the eval-reports-bucket WorkflowTemplate param (null -> empty string)#36
Merged
Merged
Conversation
…ll -> empty string)
The eval-runner WorkflowTemplate's eval-reports-bucket parameter used an unquoted
`value: REPLACE_BY_APPLICATIONSET`. When the bucket is empty (the chart default — eks-gitops injects
it per-cluster from an annotation that's blank until cluster-bootstrap publishes it), the substitution
produced `value:` which YAML parses as null. Argo Workflows v4.0+ (chart 1.0.x) rejects a null
parameter value ("must be of type string"); v3.6 accepted it, so this only surfaced once argo-workflows
was bumped across the major. Quoting the placeholder keeps an empty substitution a valid empty string.
Caught by a kx (kind) live apply against the v4.0 CRD — helm template + kubeconform missed it
(kubeconform skips the WorkflowTemplate CRD schema; `value:` is valid YAML). Chart 0.2.0 -> 0.2.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The eval-runner
WorkflowTemplate'seval-reports-bucketparam usedvalue: REPLACE_BY_APPLICATIONSET(unquoted). When the bucket is empty (chart default — eks-gitops injects it per-cluster from an annotation that's blank until cluster-bootstrap publishes it), the substitution yieldsvalue:→ YAML null. Argo Workflows v4.0+ (chart1.0.x, just bumped) rejects a null param value (must be of type string); v3.6 accepted it — so this only surfaced after the argo-workflows major bump. Quoted the placeholder so an empty substitution stays an empty string.How it was caught
A kx (kind) live apply against the real v4.0 Argo CRD —
helm template+kubeconformmissed it (kubeconform skips the WorkflowTemplate CRD schema;value:is valid YAML, just null). This is the value of the live pass.Verification
Re-ran the operator install on the live kx cluster (v4.0 CRD present): WorkflowTemplate applies,
param[7]=eval-reports-bucket=""(string), operator 2/2 Ready. Chart0.2.0 → 0.2.1.