Prefix checking with custom entitlements is too restrictive#14
Open
jiehanzheng wants to merge 1 commit intonanonation:masterfrom
Open
Prefix checking with custom entitlements is too restrictive#14jiehanzheng wants to merge 1 commit intonanonation:masterfrom
jiehanzheng wants to merge 1 commit intonanonation:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please correct me if I'm wrong - but it seems that currently the 'application-identifier' check in entitlements requires that it matches the app id prefix in provisioning profile exactly. I tested and found out that, at least on iOS 9.1, iOS also accepts the app if the 'application-identifier' in entitlements begins with the app id prefix in provisioning profile.
I changed the script so that it will accept an entitlements as long as the 'application-identifier' begins with the app id prefix in provisioning profile.