Expose only largest field in union.fields to prevent ffi-napi size ov…#1
Merged
Merged
Conversation
…ercounting ffi-napi sums union.fields sizes when determining return value ABI, causing unions to appear larger than they are. On 64-bit x86 Windows this triggers memory corruption when an 8-byte return value is treated as an indirect buffer instead of being returned in a register. Store all fields in allFields for internal use; set fields to only the largest member so ffi-napi sees the correct size. Bumps version to 1.0.2. Fixes from node-ffi-napi#14 by @shepmaster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffi-napi sums union.fields sizes when determining return value ABI, causing unions to appear larger than they are. On 64-bit x86 Windows this triggers memory corruption when an 8-byte return value is treated as an indirect buffer instead of being returned in a register.
Store all fields in allFields for internal use; set fields to only the largest member so ffi-napi sees the correct size.
Fixes from node-ffi-napi#14 by @shepmaster