HARMONY-2237: Downgrade sqlite to fix error building in Bamboo.#876
HARMONY-2237: Downgrade sqlite to fix error building in Bamboo.#876chris-durbin merged 2 commits intomainfrom
Conversation
📝 WalkthroughWalkthroughA sqlite3 dependency version is downgraded from ^6.0.1 to ^5.1.7 in the services/harmony package configuration. No behavioral changes or control flow modifications are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.Add a configuration file to your project to customize how CodeRabbit runs oxc. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
services/harmony/package.json (1)
157-157: Pinsqlite3exactly and document inlockedDependenciesCommentsfor CI stability.The caret range
^5.1.7allows drift to later 5.x releases, which could cause non-deterministic builds in CI. The lockfile currently resolves to 5.1.7 exactly, but pinning the version in package.json and documenting it inlockedDependenciesComments(following the established pattern in the file) prevents future drift.Proposed change
- "sqlite3": "^5.1.7", + "sqlite3": "5.1.7","lockedDependenciesComments": { + "sqlite3": "Pinned to 5.1.7 to avoid Bamboo/native build regressions.",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@services/harmony/package.json` at line 157, Update package.json to pin the sqlite3 dependency to the exact version "5.1.7" instead of using the caret range "^5.1.7" and add an explanatory entry for this package under the lockedDependenciesComments object; locate the sqlite3 line in services/harmony/package.json, remove the caret from the version string (change ^5.1.7 to 5.1.7) and add a comment entry in lockedDependenciesComments keyed by "sqlite3" describing that the version is pinned for CI/build stability to prevent drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@services/harmony/package.json`:
- Line 157: Update package.json to pin the sqlite3 dependency to the exact
version "5.1.7" instead of using the caret range "^5.1.7" and add an explanatory
entry for this package under the lockedDependenciesComments object; locate the
sqlite3 line in services/harmony/package.json, remove the caret from the version
string (change ^5.1.7 to 5.1.7) and add a comment entry in
lockedDependenciesComments keyed by "sqlite3" describing that the version is
pinned for CI/build stability to prevent drift.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bdaed12c-d7b4-43d4-85cc-e4d826fb4d26
⛔ Files ignored due to path filters (1)
services/harmony/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
services/harmony/package.json
Jira Issue ID
HARMONY-2237
Description
HARMONY-2237: Downgrade sqlite to fix error building in Bamboo.
Local Test Steps
npm run better-auditPR Acceptance Checklist
Summary by CodeRabbit