A few zooming in/out with plots display issue fixes.#8199
Open
shefalijoshi wants to merge 20 commits intomasterfrom
Open
A few zooming in/out with plots display issue fixes.#8199shefalijoshi wants to merge 20 commits intomasterfrom
shefalijoshi wants to merge 20 commits intomasterfrom
Conversation
…er if they're going to be visible. This reduces the relative time delta - thus reducing chances to overflow a Float32
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8199 +/- ##
==========================================
- Coverage 57.21% 55.93% -1.28%
==========================================
Files 728 728
Lines 29676 29719 +43
Branches 2804 2811 +7
==========================================
- Hits 16978 16624 -354
- Misses 12358 12755 +397
Partials 340 340
... and 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jvigliotta
added a commit
that referenced
this pull request
Nov 10, 2025
…panning. includes the exact edge points needed (1 before, 1 after visible range)
…for line continuation
shefalijoshi
commented
Feb 9, 2026
| }, this); | ||
|
|
||
| const data = this.series.getSeriesData(); | ||
| if (!data || data.length === 0) { |
…ot to prevent rendering artifacts.
Contributor
NOTEMerge this before #8274 |
akhenry
requested changes
Mar 19, 2026
Contributor
akhenry
left a comment
There was a problem hiding this comment.
I want to discuss this before it goes in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7926 #6433 #7928
Describe your changes:
Plots use WebGL to display data points. WebGL (1.0 and 2.0) only work with 32-bit data.
Plots use the 'relative coordinate' strategy to reduce the size of data points (like timestamps in milliseconds) from 64-bit to 32-bit numbers.
This is done by:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist