Skip to content

Sanitize domainObject names when present in a CVS export#8299

Open
jvigliotta wants to merge 5 commits intomasterfrom
vipergc-997
Open

Sanitize domainObject names when present in a CVS export#8299
jvigliotta wants to merge 5 commits intomasterfrom
vipergc-997

Conversation

@jvigliotta
Copy link
Copy Markdown
Contributor

Closes VIPERGC-997

Describe your changes:

Added a sanitization method to the current CVS exporter file that can be used where ever the CVS exporter is used. Using this method in Tables when being exported, specifically on the name column. Added a test to cover the main injection types for CVS injection exploits.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.26%. Comparing base (9a855cf) to head (62cc1d2).

Files with missing lines Patch % Lines
...ugins/telemetryTable/components/TableComponent.vue 0.00% 6 Missing ⚠️
src/exporters/CSVExporter.js 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8299      +/-   ##
==========================================
+ Coverage   57.21%   57.26%   +0.04%     
==========================================
  Files         728      728              
  Lines       29676    29687      +11     
  Branches     2804     2805       +1     
==========================================
+ Hits        16978    16999      +21     
+ Misses      12358    12348      -10     
  Partials      340      340              
Flag Coverage Δ
e2e-ci 64.55% <66.66%> (+0.11%) ⬆️
e2e-full 39.49% <0.00%> (+0.01%) ⬆️
unit 46.39% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
src/exporters/CSVExporter.js 81.81% <66.66%> (+81.81%) ⬆️
...ugins/telemetryTable/components/TableComponent.vue 44.00% <0.00%> (-0.53%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a855cf...62cc1d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akhenry akhenry removed their assignment Apr 28, 2026
@akhenry akhenry requested a review from davetsay April 28, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants