Sanitize domainObject names when present in a CVS export#8299
Open
jvigliotta wants to merge 5 commits intomasterfrom
Open
Sanitize domainObject names when present in a CVS export#8299jvigliotta wants to merge 5 commits intomasterfrom
jvigliotta wants to merge 5 commits intomasterfrom
Conversation
…les, add test for each injection type
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8299 +/- ##
==========================================
+ Coverage 57.21% 57.26% +0.04%
==========================================
Files 728 728
Lines 29676 29687 +11
Branches 2804 2805 +1
==========================================
+ Hits 16978 16999 +21
+ Misses 12358 12348 -10
Partials 340 340
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes VIPERGC-997
Describe your changes:
Added a sanitization method to the current CVS exporter file that can be used where ever the CVS exporter is used. Using this method in Tables when being exported, specifically on the name column. Added a test to cover the main injection types for CVS injection exploits.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist