Skip to content

frame: store borrowed values#13

Merged
nbari merged 2 commits into
nbari:developfrom
famfo:ranch
Mar 9, 2026
Merged

frame: store borrowed values#13
nbari merged 2 commits into
nbari:developfrom
famfo:ranch

Conversation

@famfo
Copy link
Copy Markdown
Contributor

@famfo famfo commented Mar 9, 2026

Reduces the amount of some allocations. I am aware that this is a breaking change but in my application this takes out a large chunk of them and now I'm mainly waiting for syscalls ^^'

Maybe it could be a possibility to pre-allocate the entire serialization buffer as well, I'd do that in a separate PR though if I end up looking into that more.


  • Have you test the code?
  • Have you check that the existing tests are passing?
  • The destination branch is develop?

@chantra
Copy link
Copy Markdown
Contributor

chantra commented Mar 9, 2026

I am very much looking for this, this was something I had in mind. I will try to test the change.

@nbari nbari merged commit 4e4bbbb into nbari:develop Mar 9, 2026
5 checks passed
@nbari
Copy link
Copy Markdown
Owner

nbari commented Mar 9, 2026

Hi @famfo, @chantra, out of curiosity, what are you using this for? (my use case is mainly logging)

@famfo
Copy link
Copy Markdown
Contributor Author

famfo commented Mar 9, 2026

I've contributed HAProxy SPOA support for iocaine using this

@chantra
Copy link
Copy Markdown
Contributor

chantra commented Mar 10, 2026

I use it to capture the ja4 of requests we are receiving. This was a use-case to evaluate if it was a valuable solution. We are planning to use it to put some of the internal custom decision tree that can't be done in haproxy into SPOP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants