ncyBreadcrumbLabel can be build by text or function#136
Open
Krolock1 wants to merge 1 commit intoncuillery:masterfrom
Krolock1:master
Open
ncyBreadcrumbLabel can be build by text or function#136Krolock1 wants to merge 1 commit intoncuillery:masterfrom Krolock1:master
Krolock1 wants to merge 1 commit intoncuillery:masterfrom
Krolock1:master
Conversation
Author
|
with this extention it is possible to define the label of the breadcrumb as string or as callback function that is called with with viewScope as parameter. |
Owner
|
Hi, many thanks for the PR. At first glance, it looks good to me. I can't merge it for the moment: I need to fix tests (#135) before. Then I'll test this stuff. |
|
Hi, Is this updated to the plugin ? can we use label function like parent ? |
Owner
|
Hi @Krolock1, can you rebase your PR please ? Tests should be working. |
Author
|
It's my first time that I will do a rebase, so I have to look how to do. |
|
I like this, it looks good to me too. Would be awesome if it got merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.