Correction of marine_acoustics DVL message packing.#2
Open
jbedwani wants to merge 1 commit intondahn:masterfrom
Open
Correction of marine_acoustics DVL message packing.#2jbedwani wants to merge 1 commit intondahn:masterfrom
jbedwani wants to merge 1 commit intondahn:masterfrom
Conversation
avyan-k
added a commit
to mcgill-robotics/dvl_a50
that referenced
this pull request
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once we activate the acoustic_enabled flag. The a50 start sending another message. This one used for publishing the velocity topic. However the marice_acoustic message is improperly accessed while packing its fields with the received message, causing the code to throw an error. Field structure were using the previous message format.