Fix event vacancy fill to maintain strict waitlist order #11162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a vacancy opens in a bucket, the service now tries harder to accommodate waitlisted signups in strict chronological order. If the first person on the waitlist wants a different bucket that's full, the service will move a no-preference signup to an alternate bucket to make room, rather than skipping to the next person on the waitlist. This ensures fairness by respecting the order people joined the waitlist, even when their preferred bucket requires shuffling other signups. Fixes #11154 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Added comments to try_make_room_in_requested_bucket and try_make_room_for_waitlisted_signup to clarify their distinct purposes: - try_make_room_in_requested_bucket uses an existing vacancy to help waitlisted signups who want different buckets - try_make_room_for_waitlisted_signup creates a vacancy when the target bucket is full Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11154.
Summary
Changes
Bug Fix
The main issue was that the service would find any signup that could fill a vacancy, potentially skipping over earlier waitlisted people. The fix ensures waitlisted signups are processed in order and tries multiple strategies to accommodate each one:
Documentation
Added comments to
try_make_room_in_requested_bucketandtry_make_room_for_waitlisted_signupto clarify their distinct purposes:try_make_room_in_requested_bucket: Uses an existing vacancy to help waitlisted signups who want different bucketstry_make_room_for_waitlisted_signup: Creates a vacancy when the target bucket is full by finding a third bucketTest plan
🤖 Generated with Claude Code