[Snyk] Upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0#569
[Snyk] Upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0#569nejidevelops wants to merge 1 commit intomasterfrom
Conversation
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0. See this package in npm: @testing-library/jest-dom See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/f7d66971-0e4e-4b4f-b41b-9d3ea4b58dea?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades @testing-library/jest-dom from 5.11.9 to 5.17.0. While keeping dependencies current is important, this particular upgrade introduces a critical incompatibility with other testing libraries in your project due to conflicting versions of the transitive dependency @testing-library/dom. This will likely cause your test suite to fail. I have added a review comment with a detailed explanation and a code suggestion to upgrade to a compatible version instead. It is highly recommended to address this issue before merging.
| "main": "index.js", | ||
| "dependencies": { | ||
| "@testing-library/jest-dom": "^5.11.9", | ||
| "@testing-library/jest-dom": "^5.17.0", |
There was a problem hiding this comment.
This upgrade introduces a dependency conflict that will likely break your tests.
@testing-library/jest-dom@5.17.0(this PR) depends on@testing-library/dom@^9.3.1.- Your project's
@testing-library/react@11.2.5depends on@testing-library/dom@^7.29.4.
Using multiple major versions of @testing-library/dom is unsupported and leads to errors. Your project is constrained to @testing-library/dom v7 because you are using React 16, which limits @testing-library/react to v11.
To fix this, I suggest upgrading to the latest version of @testing-library/jest-dom that is compatible with @testing-library/dom v7, which is 5.11.10.
As a further improvement, consider updating other testing libraries to their latest patch versions to maintain consistency:
@testing-library/reactto^11.2.7@testing-library/user-eventto^12.8.3
| "@testing-library/jest-dom": "^5.17.0", | |
| "@testing-library/jest-dom": "^5.11.10", |
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 14 versions ahead of your current version.
The recommended version was released 3 years ago.
Release notes
Package name: @testing-library/jest-dom
-
5.17.0 - 2023-07-18
- New
-
5.16.5 - 2022-08-04
- migrate ccs v3 to @ adobe/css-tools v4 (#470) (948d90f)
-
5.16.4 - 2022-04-05
- Support unenclosed inner text for details elements in to be visible (#396) (af18453)
-
5.16.3 - 2022-03-24
- clarify toHaveFocus message when using
-
5.16.2 - 2022-02-03
- add custom element support to
-
5.16.1 - 2021-12-06
- Improve
-
5.16.0 - 2021-12-03
- Update aria-query to 5.0.0 (#414) (de26c7a)
-
5.15.1 - 2021-11-23
- wrong deprecate error message (#422) (dfcefa2)
-
5.15.0 - 2021-11-02
- import parse directly from css (#415) (4cb606c)
-
5.14.1 - 2021-06-11
- Updates deprecated matchers info (#378) (fc9ce6d)
-
5.14.0 - 2021-06-11
-
5.13.0 - 2021-06-03
-
5.12.0 - 2021-04-22
-
5.11.10 - 2021-03-25
-
5.11.9 - 2021-01-12
from @testing-library/jest-dom GitHub release notes5.17.0 (2023-07-18)
Features
toHaveAccessibleErrorMessagebetter implementing the spec, deprecatetoHaveErrorMessage(#503) (d717c66)5.16.5 (2022-08-04)
Bug Fixes
5.16.4 (2022-04-05)
Bug Fixes
5.16.3 (2022-03-24)
Bug Fixes
.not(#447) (6988a67)5.16.2 (2022-02-03)
Bug Fixes
toBeDisabled(#368) (8162115)5.16.1 (2021-12-06)
Bug Fixes
toHaveClasserror message format (#405) (a9beb47)5.16.0 (2021-12-03)
Features
5.15.1 (2021-11-23)
Bug Fixes
5.15.0 (2021-11-02)
Features
5.14.1 (2021-06-11)
Bug Fixes
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: