Skip to content

[Snyk] Upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0#569

Open
nejidevelops wants to merge 1 commit intomasterfrom
snyk-upgrade-99036aa248bc027937e8ee710f2d840a
Open

[Snyk] Upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0#569
nejidevelops wants to merge 1 commit intomasterfrom
snyk-upgrade-99036aa248bc027937e8ee710f2d840a

Conversation

@nejidevelops
Copy link
Copy Markdown
Owner

snyk-top-banner

Snyk has created this PR to upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 14 versions ahead of your current version.

  • The recommended version was released 3 years ago.

Release notes
Package name: @testing-library/jest-dom from @testing-library/jest-dom GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0.

See this package in npm:
@testing-library/jest-dom

See this project in Snyk:
https://app.snyk.io/org/newtonombese1/project/f7d66971-0e4e-4b4f-b41b-9d3ea4b58dea?utm_source=github&utm_medium=referral&page=upgrade-pr
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the @testing-library/jest-dom dependency to its latest recommended version. This automated upgrade ensures the project benefits from the most recent features, performance enhancements, and critical security fixes, contributing to a more stable and secure development environment.

Highlights

  • Dependency Upgrade: The @testing-library/jest-dom package has been upgraded from version 5.11.9 to 5.17.0. This upgrade was initiated by Snyk to keep dependencies up-to-date for security and maintenance.
  • New Features and Bug Fixes: The upgrade spans 14 versions and includes new features such as toHaveAccessibleErrorMessage (deprecating toHaveErrorMessage), various bug fixes like migrating CSS tools, supporting unenclosed inner text for details elements, and improvements to error messages and custom element support.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • 0x05-react_state/task_0/dashboard/package.json
    • Updated the version of @testing-library/jest-dom in the dependencies section from ^5.11.9 to ^5.17.0.
Activity
  • The pull request was automatically created by Snyk to propose an upgrade for the @testing-library/jest-dom dependency.
  • No human comments or reviews have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades @testing-library/jest-dom from 5.11.9 to 5.17.0. While keeping dependencies current is important, this particular upgrade introduces a critical incompatibility with other testing libraries in your project due to conflicting versions of the transitive dependency @testing-library/dom. This will likely cause your test suite to fail. I have added a review comment with a detailed explanation and a code suggestion to upgrade to a compatible version instead. It is highly recommended to address this issue before merging.

"main": "index.js",
"dependencies": {
"@testing-library/jest-dom": "^5.11.9",
"@testing-library/jest-dom": "^5.17.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade introduces a dependency conflict that will likely break your tests.

  • @testing-library/jest-dom@5.17.0 (this PR) depends on @testing-library/dom@^9.3.1.
  • Your project's @testing-library/react@11.2.5 depends on @testing-library/dom@^7.29.4.

Using multiple major versions of @testing-library/dom is unsupported and leads to errors. Your project is constrained to @testing-library/dom v7 because you are using React 16, which limits @testing-library/react to v11.

To fix this, I suggest upgrading to the latest version of @testing-library/jest-dom that is compatible with @testing-library/dom v7, which is 5.11.10.

As a further improvement, consider updating other testing libraries to their latest patch versions to maintain consistency:

  • @testing-library/react to ^11.2.7
  • @testing-library/user-event to ^12.8.3
Suggested change
"@testing-library/jest-dom": "^5.17.0",
"@testing-library/jest-dom": "^5.11.10",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants