Skip to content

Fix newline JSON unmarshalling bug#177

Merged
vivientran42 merged 6 commits into
mainfrom
fix/newline-json-unmarshalling
May 14, 2026
Merged

Fix newline JSON unmarshalling bug#177
vivientran42 merged 6 commits into
mainfrom
fix/newline-json-unmarshalling

Conversation

@vivientran42
Copy link
Copy Markdown
Contributor

@vivientran42 vivientran42 commented May 11, 2026

Fixing bug described in #112

Found that the newline results in the resbody being returned as HTML instead of JSON, causing an error with unmarshalling and leading to a panic.

Addressed same issue for a few other commands.

Comment thread neo4j-cli/aura/internal/subcommands/tenant/get_test.go
@vivientran42 vivientran42 marked this pull request as ready for review May 11, 2026 15:35
@vivientran42 vivientran42 requested a review from a team as a code owner May 11, 2026 15:35
Copy link
Copy Markdown
Member

@angrykoala angrykoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a patch changelog entry (with changie)

You can follow the instructions here to create it

@vivientran42 vivientran42 requested a review from angrykoala May 14, 2026 09:55
@vivientran42 vivientran42 merged commit 29a1099 into main May 14, 2026
9 checks passed
@vivientran42 vivientran42 deleted the fix/newline-json-unmarshalling branch May 14, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when a single double quote used and then another given when prompted

3 participants