Readd support for client and server sides and update to 26.1-snapshot-11#29
Open
coehlrich wants to merge 9 commits intoneoforged:mainfrom
Open
Readd support for client and server sides and update to 26.1-snapshot-11#29coehlrich wants to merge 9 commits intoneoforged:mainfrom
coehlrich wants to merge 9 commits intoneoforged:mainfrom
Conversation
Last commit published: deffdb6ea755ed70b70476ac64877817f163e36f - version: PR PublishingThe artifacts published by this PR:Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name = "Maven for PR #29" // https://github.com/neoforged/NeoForm/pull/29
url = uri("https://prmaven.neoforged.net/NeoForm/pr29")
content {
includeModule("net.neoforged", "neoform")
}
}
} |
Contributor
We generally don't do more work because others might be using it. |
Member
|
Seconded. We need a clear motivation for why it is needed. As far as I know, nobody complained that we removed it. ;) |
15bbb36 to
d79926c
Compare
|
@coehlrich, this pull request has conflicts, please resolve them for this PR to move forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client and server sides shouldn't have been removed in the first place since other projects may be using them.