Skip to content

fix(PL-5476): handle empty output from gh label list --json #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silphid merged 1 commit into from
Apr 28, 2026
+8 −2
Merged

fix(PL-5476): handle empty output from gh label list --json #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/github/pull_request_provider.go
View file
Open in desktop
Comment thread
adriangarcia-nesto marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package github

import (
"bytes"
"encoding/json"
"fmt"
"os/exec"
Expand Down Expand Up @@ -214,9 +215,14 @@ func (p *PullRequestProvider) createLabels(labels ...string) error {
return fmt.Errorf("listing labels: %s", output)
}

// `gh label list --json` returns empty output when the repo has no labels,
// which is not valid JSON and would fail to unmarshal.
output = bytes.TrimSpace(output)
var existingLabels []label
if err := json.Unmarshal(output, &existingLabels); err != nil {
return fmt.Errorf("unmarshaling label list: %w", err)
if len(output) > 0 {
if err := json.Unmarshal(output, &existingLabels); err != nil {
return fmt.Errorf("unmarshaling label list: %w", err)
}
}
existingLabelSet := make(map[string]bool)
for _, existingLabel := range existingLabels {
Expand Down
Loading