feat: add NULL and CAA record type support and fix server EDNS mtu advertisement#70
Merged
Merged
Conversation
|
perfection! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
NULLandCAArecord type support with minimal changes to the existing record-type pipeline.It also includes two small server-side MTU/EDNS cleanups:
-mtuwas incorrectly shown for record types where-mtustill applies-mtuinstead of a hardcoded4096Changes
NULLandCAAto record type parsing and CLI flagsNULLandCAAencode/decode support on client and serverTXT,NULL, andCAA-mtuwarning only for name-limited record types:CNAME,NS,MX, andSRV4096Why change the EDNS response advertisement
This is a small consistency fix.
Before this change, the authoritative server always put
4096in the response OPT RR, even when the actual response sizing logic was using the configured-mtu.This change makes the response OPT RR follow the same configured limit that the server already uses for response sizing and truncation.
This does not change the existing acceptance logic for small-EDNS resolvers. It is mainly a cleanup so the response advertisement matches the server's actual configured ceiling.
Notes
-dnstt-compatbehavior is unchanged for wire format and still forcesTXT-mtuwarning now only appears for record types whose downstream capacity is actually bounded by DNS name length instead of UDP payload size