Fix PhpStan suggestions by janbarasek · Pull Request #378 · nette/tracy

janbarasek · 2019-08-10T20:58:46Z

bug fix
BC break? yes

Fixed PhpStan suggestions.

New errors:

------ ------------------------------------------------------------------------ 
 Line   Bridges/Nette/TracyExtension.php                                        
------ ------------------------------------------------------------------------ 
 103    Cannot access property $netteMailer on array|object.                    
 105    Cannot access property $fromEmail on array|object.                      
 110    Cannot access property $bar on array|object.                            
 112    Strict comparison using === between '' and '@' will always evaluate to  
        false.                                                                  
 130    Cannot access property $blueScreen on array|object.                     
------ ------------------------------------------------------------------------ 

------ ------------------------------------------------------------------- 
 Line   Tracy/Debugger/Debugger.php                                        
------ ------------------------------------------------------------------- 
 374    Access to an undefined property ErrorException::$context.          
 379    Access to an undefined property ErrorException::$context.          
 387    Access to an undefined property ErrorException::$context.          
 401    Access to an undefined property ErrorException::$context.          
 402    Access to an undefined property ErrorException::$skippable.        
 407    Access to an undefined property Tracy\IBarPanel::$data.            
 446    Negated boolean expression is always false.                        
 460    Negated boolean expression is always false.                        
 463    Access to an undefined property Tracy\DefaultBarPanel::$cpuUsage.  
 478    Negated boolean expression is always false.                        
 489    Negated boolean expression is always false.                        
------ ------------------------------------------------------------------- 

------ ------------------------------------------------------------------- 
 Line   Tracy/Dumper/Dumper.php                                            
------ ------------------------------------------------------------------- 
 505    Parameter #1 $character of function ord expects string, float|int  
        given.                                                             
------ ------------------------------------------------------------------- 

------ ---------------------------------------------------------- 
 Line   Tracy/Helpers.php                                         
------ ---------------------------------------------------------- 
 214    Access to an undefined property Throwable::$tracyAction.  
------ ----------------------------------------------------------

Old errors:

------ ------------------------------------------------------------------------- 
 Line   Bridges/Nette/Bridge.php                                                 
------ ------------------------------------------------------------------------- 
 36     Class Latte\CompileException not found.                                  
 39     Access to property $sourceName on an unknown class                       
        Latte\CompileException.                                                  
 42     Access to property $sourceName on an unknown class                       
        Latte\CompileException.                                                  
 43     Access to property $sourceLine on an unknown class                       
        Latte\CompileException.                                                  
 43     Access to property $sourceName on an unknown class                       
        Latte\CompileException.                                                  
 44     Access to property $sourceLine on an unknown class                       
        Latte\CompileException.                                                  
 44     Access to property $sourceLine on an unknown class                       
        Latte\CompileException.                                                  
 44     Access to property $sourceName on an unknown class                       
        Latte\CompileException.                                                  
 47     Access to property $sourceCode on an unknown class                       
        Latte\CompileException.                                                  
 47     Access to property $sourceLine on an unknown class                       
        Latte\CompileException.                                                  
 72     Class Latte\CompileException not found.                                  
 73     Access to property $sourceName on an unknown class                       
        Latte\CompileException.                                                  
 74     Call to method getMessage() on an unknown class Latte\CompileException.  
 75     Call to method getMessage() on an unknown class Latte\CompileException.  
 78     Access to property $sourceLine on an unknown class                       
        Latte\CompileException.                                                  
 78     Access to property $sourceName on an unknown class                       
        Latte\CompileException.                                                  
------ ------------------------------------------------------------------------- 

------ ------------------------------------------------------------------------- 
 Line   Bridges/Nette/MailSender.php                                             
------ ------------------------------------------------------------------------- 
 24     Property Tracy\Bridges\Nette\MailSender::$mailer has unknown class       
        Nette\Mail\IMailer as its type.                                          
 30     Parameter $mailer of method                                              
        Tracy\Bridges\Nette\MailSender::__construct() has invalid typehint type  
        Nette\Mail\IMailer.                                                      
 44     Instantiated class Nette\Mail\Message not found.                         
 45     Call to method setHeader() on an unknown class Nette\Mail\Message.       
 47     Call to method setFrom() on an unknown class Nette\Mail\Message.         
 50     Call to method addTo() on an unknown class Nette\Mail\Message.           
 52     Call to method setSubject() on an unknown class Nette\Mail\Message.      
 53     Call to method setBody() on an unknown class Nette\Mail\Message.         
 55     Call to method send() on an unknown class Nette\Mail\IMailer.            
------ ------------------------------------------------------------------------- 

------ ------------------------------------------------------ 
 Line   Bridges/Nette/TracyExtension.php                      
------ ------------------------------------------------------ 
 103    Cannot access property $netteMailer on array|object.  
 103    Class Nette\Mail\IMailer not found.                   
 105    Cannot access property $fromEmail on array|object.    
 110    Cannot access property $bar on array|object.          
 122    Class Nette\Http\Session not found.                   
 128    Cannot access property $blueScreen on array|object.   
------ ------------------------------------------------------ 

------ ------------------------------------------------------------------------ 
 Line   Tracy/Debugger/Debugger.php                                             
------ ------------------------------------------------------------------------ 
 31     Static property Tracy\Debugger::$productionMode (bool) does not accept  
        default value of type null.                                             
 374    Access to an undefined property ErrorException::$context.               
 379    Access to an undefined property ErrorException::$context.               
 387    Access to an undefined property ErrorException::$context.               
 401    Access to an undefined property ErrorException::$context.               
 402    Access to an undefined property ErrorException::$skippable.             
 407    Access to an undefined property Tracy\IBarPanel::$data.                 
 446    Negated boolean expression is always false.                             
 460    Negated boolean expression is always false.                             
 463    Access to an undefined property Tracy\DefaultBarPanel::$cpuUsage.       
 478    Negated boolean expression is always false.                             
 489    Negated boolean expression is always false.                             
------ ------------------------------------------------------------------------ 

------ ------------------------------------------------------------------- 
 Line   Tracy/Dumper/Dumper.php                                            
------ ------------------------------------------------------------------- 
 185    Variable $options might not be defined.                            
 189    Variable $options might not be defined.                            
 192    Variable $options might not be defined.                            
 504    Parameter #1 $character of function ord expects string, float|int  
        given.                                                             
 545    PHPDoc tag @param references unknown parameter: $k                 
------ ------------------------------------------------------------------- 

------ ---------------------------------------------------------- 
 Line   Tracy/Helpers.php                                         
------ ---------------------------------------------------------- 
 215    Access to an undefined property Throwable::$tracyAction.  
 216    Variable $replace might not be defined.                   
 216    Variable $replace might not be defined.                   
 253    Variable $i might not be defined.                         
 254    Variable $i might not be defined.                         
 255    Variable $i might not be defined.                         
 255    Variable $i might not be defined.                         
------ ---------------------------------------------------------- 

------ ---------------------------------- 
 Line   Tracy/Logger/Logger.php           
------ ---------------------------------- 
 166    Right side of && is always true.  
------ ----------------------------------

…open-to-window links

src/Bridges/Nette/Bridge.php

src/Bridges/Nette/MailSender.php

src/Tracy/Dumper/Dumper.php

JanTvrdik · 2019-08-11T06:40:01Z

src/Tracy/Logger/Logger.php


 		if (
 			$this->email
-			&& $this->mailer


this is wrong fix, instead the type of the $mailer property should be changed to callable|null

Ok, now I understand. In original implementation property $mailer was setted by __construct in all cases. But property is public and can be changed.

I reverted condition here and change property definition:

/** @var callable|null handler for sending emails */ public $mailer;

JanTvrdik · 2019-08-11T06:41:41Z

src/Bridges/Nette/TracyExtension.php

-					$item = new Nette\DI\Statement(['@' . $builder::THIS_CONTAINER, 'getService'], [substr($item, 1)]);
-				} elseif (is_string($item)) {
-					$item = new Nette\DI\Statement($item);
+				if (is_string($item)) {


Because in original implementation when you verify variable $item is string, second elseif condition does not make sense.

src/Bridges/Nette/TracyExtension.php

src/Tracy/Helpers.php

JanTvrdik · 2019-08-11T06:43:53Z

src/Tracy/Dumper/Dumper.php

 				$maxI = $maxLength * 4; // max UTF-8 length
 				do {
-					if (($s[$i] < "\x80" || $s[$i] >= "\xC0") && (++$len > $maxLength) || $i >= $maxI) {
+					if (($s[$i] < "\x80" || $s[$i] >= "\xC0") && ((++$len > $maxLength) || $i >= $maxI)) {


Operations priority might differ from what programmer expect. Brackets are safe.

if it's not related the phpstan error it should not be part of this PR

src/Bridges/Nette/Bridge.php

JanTvrdik

you should not mix code changes related to phpstan errors with code style changes in one PR

dg and others added 10 commits August 5, 2019 13:35

opened 2.7-dev

57d7ec8

bar: replaced attribute 'rel' with 'data-tracy-action' for closing & …

250c622

…open-to-window links

Bluescreen: footer is always on bottom

e3996eb

BlueScreen: removed source from footer

ee22c3c

Logger: added priority to exception file name

1d8b780

TracyExtension: added getConfigSchema()

fdaefa2

tested against PHP 7.4

6060d6c

Fix PhpStan suggestions

be818cc

Helpers: Revert write to undefined propert tracyAction

dc60c08

Bridge: CodeStyle

6292e07

JanTvrdik suggested changes Aug 11, 2019

View reviewed changes

janbarasek added 2 commits August 11, 2019 10:34

Composer: Added new dev dependencies

ae2c34f

Fix by JanTvrdik suggestions

85c9611

mabar reviewed Aug 11, 2019

View reviewed changes

src/Bridges/Nette/Bridge.php Outdated Show resolved Hide resolved

Bridge: Use dev dependency and remove assert

3e52f92

JanTvrdik reviewed Aug 11, 2019

View reviewed changes

dg force-pushed the master branch from 8b6796a to 3b69b81 Compare August 19, 2019 16:12

dg force-pushed the master branch from e42541b to 9270a2c Compare September 13, 2019 10:03

dg force-pushed the master branch 2 times, most recently from dbabb37 to eb2e772 Compare September 24, 2019 11:11

dg force-pushed the master branch 6 times, most recently from de3ad52 to 191c0d2 Compare December 15, 2019 22:49

dg force-pushed the master branch 2 times, most recently from 2b958bb to f36b649 Compare January 2, 2020 19:40

dg force-pushed the master branch 2 times, most recently from 68b0ec8 to 344c772 Compare February 23, 2020 18:40

dg force-pushed the master branch 10 times, most recently from c3c8bf0 to 6f7e1c3 Compare January 22, 2021 23:21

dg force-pushed the master branch from b2a4f56 to 1f2ee8d Compare January 25, 2021 00:23

dg force-pushed the master branch 2 times, most recently from 84dee11 to bd73e33 Compare March 4, 2021 20:09

dg force-pushed the master branch from 5e61930 to 2155db4 Compare April 5, 2021 13:59

dg force-pushed the master branch 8 times, most recently from 7799297 to a386d38 Compare April 29, 2021 11:09

dg force-pushed the master branch 2 times, most recently from f3f04e0 to 0a90e93 Compare May 10, 2021 11:10

dg force-pushed the master branch 6 times, most recently from 5ee33d7 to 8e708de Compare August 24, 2021 16:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix PhpStan suggestions#378

Fix PhpStan suggestions#378
janbarasek wants to merge 22 commits intonette:masterfrom
janbarasek:phpstan-fix

janbarasek commented Aug 10, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanTvrdik Aug 11, 2019

Uh oh!

janbarasek Aug 11, 2019

Uh oh!

JanTvrdik Aug 11, 2019

Uh oh!

janbarasek Aug 11, 2019

Uh oh!

Uh oh!

Uh oh!

JanTvrdik Aug 11, 2019

Uh oh!

janbarasek Aug 11, 2019

Uh oh!

JanTvrdik Aug 11, 2019

Uh oh!

Uh oh!

JanTvrdik left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

janbarasek commented Aug 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanTvrdik Aug 11, 2019

Choose a reason for hiding this comment

Uh oh!

janbarasek Aug 11, 2019

Choose a reason for hiding this comment

Uh oh!

JanTvrdik Aug 11, 2019

Choose a reason for hiding this comment

Uh oh!

janbarasek Aug 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JanTvrdik Aug 11, 2019

Choose a reason for hiding this comment

Uh oh!

janbarasek Aug 11, 2019

Choose a reason for hiding this comment

Uh oh!

JanTvrdik Aug 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JanTvrdik left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

janbarasek commented Aug 10, 2019 •

edited

Loading

JanTvrdik left a comment •

edited

Loading