Conversation
Docker-compose example.
|
I think the example would be better served if it was part of the README instead of as a stand-alone file. |
|
version: 3 is not necessary. you should delete |
| - /home/dhcp:/data | ||
| network_mode: "host" | ||
| environment: | ||
| - TZ=Pacific/Auckland |
There was a problem hiding this comment.
Should not be part of the PR, as it is a personal setting.
There was a problem hiding this comment.
Can you mount read-only /etc/localtime instead and get the same behavior?
| restart: unless-stopped | ||
| ports: | ||
| # Public dhcpd Port: | ||
| - "67:67/udp" |
There was a problem hiding this comment.
Port publishing is meaningless in the host network.
| version: "3" | ||
| services: | ||
| dhcp: | ||
| image: networkboot/dhcpd:latest |
There was a problem hiding this comment.
Use a specific version instead of :latest.
| # Public dhcpd Port: | ||
| - "67:67/udp" | ||
| volumes: | ||
| - /home/dhcp:/data |
There was a problem hiding this comment.
Should not be part of the PR, as it is a personal setting.
Prefer a relative path, - ./data:/data maybe.
4 participants
Docker-compose example.
This might assist ppl in writing a docker-compose.yml for themselves