fix(airplane): correct radio presence and Bluetooth settle behavior

[cachebag]

Fixes a bug where turning airplane mode on could shut off Wi‑Fi (and Bluetooth) while clients still saw “airplane off”: failures or missing BlueZ were surfaced as errors after Wi‑Fi had already been soft‑blocked, read‑after‑write could catch Bluetooth’s Powered before it updated, and absent Wi‑Fi/WWAN/Bluetooth hardware was still folded into AirplaneModeState, so is_airplane_mode never matched what the user expected.

This change treats absent radios as not present, treats unavailable Bluetooth as a no‑op when turning airplane on so the call still succeeds for Wi‑Fi/WWAN, waits for BlueZ power state with bounded latency (one device pass plus a single overall settle timeout), and reduces redundant D‑Bus work by enumerating NM devices once for the combined state. When Bluetooth is skipped because BlueZ is unavailable, a warning is logged so “silent” failures are still diagnosable.

[Copilot]

Pull request overview

This PR refines nmrs airplane-mode behavior so hosts without certain radios (notably Bluetooth/WWAN) don’t get “stuck” in a non-airplane state and so BlueZ toggles are less prone to read-after-write races.

Changes:

• Add RadioState::present (+ with_presence) and update airplane-mode aggregation helpers to ignore absent radios.
• Treat missing/absent BlueZ as “not present” for aggregation and downgrade BluezUnavailable during set_airplane_mode to avoid failing the overall toggle.
• After setting BlueZ Powered, wait (bounded) for the property to reflect the change to reduce transient stale reads.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
nmrs/src/types/constants.rs	Adds NM device type constant for modem/WWAN detection.
nmrs/src/core/airplane.rs	Implements radio presence detection, BlueZ Powered settling wait, and set_airplane_mode behavior change for missing BlueZ.
nmrs/src/api/network_manager.rs	Updates public API docs to describe presence semantics and BlueZ no-op behavior.
nmrs/src/api/models/radio.rs	Extends RadioState with present, updates AirplaneModeState logic, and adds unit tests.
nmrs/CHANGELOG.md	Documents the new present field and airplane-mode fixes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

nmrs/src/core/airplane.rs:176

• set_bluetooth_radio_enabled wraps any error from enumerate_bluetooth_adapters into a new ConnectionError::BluezUnavailable. Since enumerate_bluetooth_adapters already returns ConnectionError (often already BluezUnavailable), this will double-prefix the error message (e.g. "bluetooth stack unavailable: failed to enumerate adapters: bluetooth stack unavailable: …") and can discard the original error variant/context. Prefer propagating the original error (?) or adding context without re-wrapping an existing ConnectionError.

    let adapter_paths = enumerate_bluetooth_adapters(conn).await.map_err(|e| {
        ConnectionError::BluezUnavailable(format!("failed to enumerate adapters: {e}"))
    })?;

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.