feat(#400): D-Proxy surface for ModemManager#415
Merged
Conversation
cachebag
added
feature
There was a problem hiding this comment.
Pull request overview
Adds a new mmrs::dbus proxy surface (zbus #[proxy] traits) for key ModemManager interfaces, aligning mmrs with the existing low-level D-Bus proxy approach used in nmrs and closing #400.
Changes:
- Introduces zbus proxy traits for
Manager,Modem,Modem.Simple,Sim, andBearerinterfaces. - Adds a
mmrs::dbusmodule that wires and re-exports the generated*Proxytypes for internal consumption. - Adds an initial
mmrscrate README describing purpose, requirements, and contribution workflow.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| mmrs/src/dbus/mod.rs | Declares ModemManager D-Bus proxy modules and re-exports generated proxy types. |
| mmrs/src/dbus/manager.rs | Adds org.freedesktop.ModemManager1 manager proxy trait (scan/logging/inhibit + version). |
| mmrs/src/dbus/modem.rs | Adds org.freedesktop.ModemManager1.Modem proxy trait (bearers/power/state/signal + StateChanged signal). |
| mmrs/src/dbus/modem_simple.rs | Adds org.freedesktop.ModemManager1.Modem.Simple proxy trait (connect/disconnect/status). |
| mmrs/src/dbus/sim.rs | Adds org.freedesktop.ModemManager1.Sim proxy trait (PIN/PUK + SIM identity properties). |
| mmrs/src/dbus/bearer.rs | Adds org.freedesktop.ModemManager1.Bearer proxy trait (connect/disconnect + IP config/stats properties). |
| mmrs/README.md | Documents mmrs goals, requirements, and contribution steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #400