Implement openconfig-system for IOS#33
Merged
dgjustice merged 3 commits intonetworktocode:ios-systemfrom Feb 19, 2020
packethost:ios-system
Merged
Implement openconfig-system for IOS#33dgjustice merged 3 commits intonetworktocode:ios-systemfrom packethost:ios-system
dgjustice merged 3 commits intonetworktocode:ios-systemfrom
packethost:ios-system
Conversation
Contributor
Author
|
I changed this to WIP after looking at PR #3 again. These two PR's really highlight the need for a little different testing setup. We need to make it easier to assert failures in particular. |
dgjustice
changed the title
Contributor
|
@dgjustice Just wanted to bump this since we merged in the testing. I know you're busy and no rush, but just wanted to let you know I'll review once it's rebased and testing follows what was merged in. |
dgjustice
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one probably needs a bit of discussion, so please review closely. "replace" operations don't always make sense on IOS, particularly for things like system-level config. There is no way to my knowledge to "default" ntp config, tacacs, users, etc. I have raised an exception when replace is called, and the test asserts off of an empty file to diff against. It's a bit hackish, but it works for now.