Conversation
This refactor removes the test magic for "merge" operations. I attempted to make the test code as concise as possible since it is pure boilerplate with this method. It does, however, give us the critical ability to address corner cases and add tests that need to rase exceptions, for example. A recent [blog post](https://testing.googleblog.com/2019/12/testing-on-toilet-tests-too-dry-make.html) backs up this line of thought, though I don't want to be accused of "monkey see, monkey do". :)
dgjustice
force-pushed
the
test-refactor
branch
from
06d292a to
9fa3ba4
Compare
dgjustice
requested review from
FragmentedPacket,
dbarrosop,
jathanism and
whitej6
FragmentedPacket
suggested changes
Jan 10, 2020
FragmentedPacket
approved these changes
Jan 31, 2020
jathanism
approved these changes
Jan 31, 2020
Contributor
jathanism
left a comment
jathanism
left a comment
There was a problem hiding this comment.
I know y'all worked hard on this. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor removes the test magic for "merge" operations.
I attempted to make the test code as concise as possible since it is pure boilerplate with this method.
It does, however, give us the critical ability to address corner cases and add tests that need to raise exceptions, for example.
A recent blog post backs up this line of thought, though I don't want to be accused of "monkey see, monkey do". :)