UF enhanced parameters to match GRF#453
Open
rflperry wants to merge 10 commits intoneurodata:stagingfrom
Open
Conversation
PSSF23
reviewed
May 6, 2021
Member
PSSF23
left a comment
There was a problem hiding this comment.
black formatting is needed on the files changed~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
None
Type of change
Feature request
What does this implement/fix?
Adds additional parameters to Uncertainty Forest to better match the generalized random forest implementations in econml, the R grf, and the theory in general. Also parallelizes the learning of the decision trees in order to speed up fitting. The added parameters are as follows: