Adding KNNClassificationDecider#463
Open
david-z-shi wants to merge 143 commits intoneurodata:KNNDeciderfrom
Open
Adding KNNClassificationDecider#463david-z-shi wants to merge 143 commits intoneurodata:KNNDeciderfrom
david-z-shi wants to merge 143 commits intoneurodata:KNNDeciderfrom
Conversation
0918 Merge
This reverts commit 7b7c0b8.
update fork
updated with main repo 10/27/2020
Co-Authored-By: jmandav1 <39231283+jmandavilli@users.noreply.github.com> Co-Authored-By: parthgvora <parthgvora@gmail.com>
Co-Authored-By: ypeng22 <68977380+ypeng22@users.noreply.github.com>
…ecision_boundaries_functions.py Co-Authored-By: jmandav1 <39231283+jmandavilli@users.noreply.github.com> Co-Authored-By: parthgvora <parthgvora@gmail.com>
Co-Authored-By: jmandav1 <39231283+jmandavilli@users.noreply.github.com> Co-Authored-By: parthgvora <parthgvora@gmail.com>
Implement SPORF
Indexing into a list using an array of integers does not work and for some reason in my use case that's what self.classes is. This simply makes the array-ness of self.classes explicit.
Pulled updates from Staging
Add an overview section (as in the [Verde](https://www.fatiando.org/verde/latest/tutorials/overview.html) documentation)
Add an overview section to the ProgLearn documentation
Optimize reference page and DOI badge
Contributor
Author
|
@jdey4 Let me know if I need to make any other changes. |
PSSF23
reviewed
May 3, 2021
Member
PSSF23
left a comment
PSSF23
left a comment
There was a problem hiding this comment.
@latasianguy And I see that the black check failed. Check the log and format your code~
PSSF23
reviewed
May 3, 2021
Member
PSSF23
left a comment
PSSF23
left a comment
There was a problem hiding this comment.
@latasianguy It's too hard to locate where you exactly changed. Could you make a list of any "new" files you added in this PR?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #461.
Type of change
Adding KNNClassificationDeciders.
What does this implement/fix?
Adding experiments for KNNClassificationDecider and the associated deciders for these experiments
Additional information
Experiments need more compute and reps.