Disable Kafka connector and gRPC, restrict backend to REST, add hygiene checks and tests#186
Closed
neuron7xLab wants to merge 16 commits intomainfrom
Closed
Disable Kafka connector and gRPC, restrict backend to REST, add hygiene checks and tests#186neuron7xLab wants to merge 16 commits intomainfrom
neuron7xLab wants to merge 16 commits intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
KafkaConnectorUnavailableErrorinsrc/.../connectors/kafka_source.pyand exported the explicit error.KafkaSourceConfigand Kafka options fromsrc/.../connectors/config.py, restrictedBackendConfig.protocolandIngestionConfig.source_typeto supported values (rest/file), and added validation to reject unsupported protocols.RemoteBackendinsrc/.../connectors/runner.pyto be REST-only, added a protocol check that raises on non-REST protocols, and consolidated HTTP client usage.scripts/generate_stakeholder_assets.pyviaPLACEHOLDER_REandassert_no_placeholders, and cleaned up a couple ofTBDentries.tests/connectors/test_fail_closed_connectors.py,tests/connectors/test_polygon_adapter_reproducible.py, andscripts/tests/test_generate_stakeholder_assets.py, and removed the legacytests/unit/data/adapters/test_polygon.py..github/workflows/pr-gate.yml) to run the new mandatory connector hygiene tests as part of the PR gate.Testing
pytest tests/ -qand the run completed successfully.pytest tests/connectors/test_fail_closed_connectors.py tests/connectors/test_polygon_adapter_reproducible.py scripts/tests/test_generate_stakeholder_assets.py -qand they passed.Codex Task