fix: collapse multiline template literal in WebSocket URL construction#445
Open
DevLikhith5 wants to merge 1 commit into
Open
fix: collapse multiline template literal in WebSocket URL construction#445DevLikhith5 wants to merge 1 commit into
DevLikhith5 wants to merge 1 commit into
Conversation
The multiline template literal in src/modules/websocket.js injects a newline and spaces into the extensionId query parameter, causing the parsed extensionId value to contain trailing whitespace. Collapsing to a single line fixes the URL. Closes neutralinojs#399
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #399.
The Bug
src/modules/websocket.jsuses a multiline template literal to construct the WebSocket URL:The newline and leading spaces between
extensionIdandconnectTokenbecome part of the URL, so the parsedextensionIdvalue contains"js.neutralino.devtools\n "instead of"js.neutralino.devtools".The Fix
Collapse the template literal to a single line. No logic change.
Checklist
fix:)Unreleased→Bugfixes/improvements