fix: validate HTTP status code in downloadTemplate to reject non-200 responses#447
Open
DevLikhith5 wants to merge 1 commit into
Open
Conversation
…responses The downloadTemplate function pipes the HTTP response directly to a file without checking response.statusCode. A non-200 response (e.g. 404) is silently treated as a successful download. Add a status code check consistent with the pattern already used in downloadClientFromRelease and downloadTypesFromRelease (added in a previous fix). Closes neutralinojs#370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #370.
The Bug
downloadTemplate()pipes the HTTP response directly to a file without checkingresponse.statusCode. A 404 or 500 is silently treated as a successful download.The Fix
Added a status code check consistent with the pattern already used in
downloadClientFromReleaseanddownloadTypesFromRelease(which were already fixed in an earlier commit):Checklist
fix:)