Skip to content

Conversation

@darshdinger
Copy link
Contributor

Short description of the changes:

Updates the plot-publisher dependency from >=1.0,<2.0 to >=1.1.0.dev1,<2.0 to address the colormap change in heatmaps that occurred after a recent update. The new version restores the expected colorscale behavior and allows for colorscale customization.

Long description of the changes:

After updating finddata, users reported that heatmap colormaps changed from the familiar rainbow/jet colorscale to a purple/magenta scale. This was due to changes in the underlying plot-publisher package that finddata imports for plotting functionality.

This PR updates the dependency constraint in both [tool.pixi.dependencies] and [tool.pixi.package.run-dependencies] sections of pyproject.toml to require version 1.1.0.dev1 or higher of plot-publisher, which includes the fix for this issue.

The change ensures that when finddata environments are redeployed with conda, the correct version of plot-publisher will be automatically picked up.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes (N/A - dependency version update only)
  • I have updated the documentation accordingly (N/A - no user-facing doc changes needed)

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

  1. Check out this branch
  2. Run pixi install to update dependencies
  3. Verify that plot-publisher version 1.1.0.dev1 is installed: pixi list | grep plot-publisher
  4. Test that finddata imports correctly: pixi run python -c "import finddata; print(finddata.__version__)"
  5. Test the CLI: pixi run finddata --version
  6. If possible, test heatmap generation to verify the colorscale is correct

References

@darshdinger darshdinger force-pushed the ewm14408-defect-fix-colormap-to-purple-scale branch from a856b90 to 136e2bd Compare December 16, 2025 19:45
@darshdinger darshdinger marked this pull request as draft December 16, 2025 19:48
Fix pixi-build-api-version configuration for build backend

Fix pixi-build-api-version configuration for build backend

Merge remote changes and fix pixi-build-api-version configuration

Update to v0.13.0 with plot-publisher v1.3.1 (Jet colorscale fix)

Fix CI: Split long test command into multiple shorter commands

Fix CI: Use single quotes for python -c commands
@darshdinger darshdinger force-pushed the ewm14408-defect-fix-colormap-to-purple-scale branch from 4cc720f to 96f3852 Compare January 5, 2026 19:46
@darshdinger darshdinger marked this pull request as ready for review January 5, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants