Conversation
AprilSylph
requested changes
Aug 5, 2020
added 2 commits
August 5, 2020 12:48
AprilSylph
requested changes
Aug 6, 2020
AprilSylph
left a comment
AprilSylph
left a comment
There was a problem hiding this comment.
i'm not especially happy with how this replaces the audio player without also providing an alternative way to see the track name, artist, album cover etc. - could the audio player be added underneath the audioBlock instead? you can reference Audio Downloader's code on how to do this
(code LGTM, but requesting behaviour changes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on Chrome 84.