Fix for OCP AlreadyReblogged icon color change#2099
Fix for OCP AlreadyReblogged icon color change#2099nobodysuspectsthebutterfly wants to merge 1 commit intonew-xkit:masterfrom
Conversation
|
The reason targeting Two solutions to this:
The reason we filter to grey reblog buttons only is to avoid clashes with Tumblr's own changing colours. Without it, AlreadyReblogged turns reblog buttons almost permanently green, overriding e.g. the purple that appears when using Tumblr's native fast-queue feature. |
|
Hm, actually it looks like Tumblr is not setting that style with perfect consistency, and there's a couple more variations that do the same thing... how annoying. We can't use RegExp in CSS selectors so I guess something more vague like |
|
For reference, the CSS used in XKit Rewritten can be seen here: AprilSylph/XKit-Rewritten@48aaf7f |
| .xkit--react .reblogged svg { | ||
| --icon-color-primary: rgb(var(--green)) !important; |
There was a problem hiding this comment.
| .xkit--react .reblogged svg { | |
| --icon-color-primary: rgb(var(--green)) !important; | |
| .xkit--react .reblogged svg[style*="--black"] use { | |
| --icon-color-primary: rgb(var(--green)); |
Re issue #2098: #2098
A tumblr update changed the selector and property for the reblog icon; this fixes the css so that AlreadyReblogged turns green as expected. Couldn't get the selector [style="--icon-color-primary:rgba(var(--black), 0.65)"] to work properly for some reason, but at least this works.